Yingyi Bu has posted comments on this change. Change subject: Improved exception handling for IFrameWriter fail() / close() ......................................................................
Patch Set 1: (3 comments) I think that later we would need to change fail() to not throw any Exception, because it is just to send the failure signal to the downstream. https://asterix-gerrit.ics.uci.edu/#/c/1837/1/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/comm/FrameWriterLifecycleHelper.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/comm/FrameWriterLifecycleHelper.java: Line 34: public static void run(IFrameWriter writer, Failable tryBlock, Failable extraCatch, Failable extraFinally) > MAJOR SonarQube violation: fix this? Line 95: hde = HyracksDataException.suppress(hde, e); > MAJOR SonarQube violation: fix this? Line 101: hde = HyracksDataException.suppress(hde, finallyEx); > MAJOR SonarQube violation: fix this? -- To view, visit https://asterix-gerrit.ics.uci.edu/1837 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib09844f03701168727ad6cf4be0e3197d8708451 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
