Yingyi Bu has posted comments on this change.

Change subject: Add Create Secondary BTree for Correlated Datasets
......................................................................


Patch Set 10:

I guess a simple fix might be to branch based on dataset.isCorrelated() in the 
method:

public static JobSpecification buildSecondaryIndexLoadingJobSpec(Dataset 
dataset, Index index,
            MetadataProvider metadataProvider) throws AlgebricksException {
        SecondaryIndexOperationsHelper secondaryIndexHelper =
                
SecondaryIndexOperationsHelper.createIndexOperationsHelper(dataset, index, 
metadataProvider,
                        physicalOptimizationConfig);
        return secondaryIndexHelper.buildLoadingJobSpec();
    }

Refactoring could be deferred to a separate change.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1813
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a3435e6720f07bd6a5092d4d9ce42e8d4b7894c
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Luo Chen <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Jianfeng Jia <[email protected]>
Gerrit-Reviewer: Luo Chen <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: Yingyi Bu <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: No

Reply via email to