Murtadha Hubail has posted comments on this change. Change subject: More reuse for ADM serialization/deserialization ......................................................................
Patch Set 7: Code-Review+2 (1 comment) Feel free to address the comment in a different change. https://asterix-gerrit.ics.uci.edu/#/c/1784/7/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/APolygonSerializerDeserializer.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/APolygonSerializerDeserializer.java: PS7, Line 88: HyracksDataException You may create an error code for this (e.g. ErrorCode.IS_NOT_POLYGON) then use: throw HyracksDataException.create(ErrorCode.IS_NOT_POLYGON, e, polygon); -- To view, visit https://asterix-gerrit.ics.uci.edu/1784 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I890a4e8de9646e9f64811f9c7331170e7f19d73b Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
