Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-1130][STO]: JSON serialization for persisted objects ......................................................................
Patch Set 8: (1 comment) (applies to all) https://asterix-gerrit.ics.uci.edu/#/c/1807/8/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/test/support/TestVirtualBufferCacheProvider.java File hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/test/support/TestVirtualBufferCacheProvider.java: PS8, Line 68: //NOSONAR Can this be changed to something like the following, so it's clear what is being suppressed, and we don't over suppress accidentally? @SuppressWarnings("squid:S1172") // unused parameter public static IJsonSerializable fromJson(... -- To view, visit https://asterix-gerrit.ics.uci.edu/1807 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I833b7e236305a3693acaea930947f7f83c8ed1fa Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
