Murtadha Hubail has posted comments on this change. Change subject: [CLUS][MTD] += ClusterStateManager pending removal ......................................................................
Patch Set 1: (5 comments) Sorry if it wasn't ready to be reviewed. https://asterix-gerrit.ics.uci.edu/#/c/1844/1//COMMIT_MSG Commit Message: Line 7: [CLUS][MTD] += ClusterStateManager pending removal You might want to add a JIRA issue for this https://asterix-gerrit.ics.uci.edu/#/c/1844/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: PS1, Line 723: " Error code? https://asterix-gerrit.ics.uci.edu/#/c/1844/1/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/dataset/hints/DatasetHints.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/dataset/hints/DatasetHints.java: PS1, Line 119: be https://asterix-gerrit.ics.uci.edu/#/c/1844/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java: PS1, Line 235: getParticipantNodes There are only 4 usages of this method. I think eventually all existing usages will have to use the excludePendingRemoval flag. Might as well just add the flag to this method and pass false in the current usages, then remove the other one. PS1, Line 411: public boolean synchronized? -- To view, visit https://asterix-gerrit.ics.uci.edu/1844 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I509a7eed727be1e339c1b75b75f778fd222cc0e2 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <hubail...@gmail.com> Gerrit-HasComments: Yes
