Ian Maxon has posted comments on this change. Change subject: [ASTERIXDB-1952][TX][IDX]Log incoming filter vals ......................................................................
Patch Set 8: > (1 comment) > > There is still a major case (i.e. the upsert case) that is not > handled in this change. There is an explicit updateFilter call > there and there is no log generated for it. The upsert is used by > all feeds so any failure during a feed ingestion will encounter > this case. That's an interesting point I hadn't considered before, you mean in LSMPrimaryUpsertOperatorNodePushable? I had thought all cases would be covered by the fact that the meat of this patch is in modify(), not specifically insert. -- To view, visit https://asterix-gerrit.ics.uci.edu/1798 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9268fe0b60145545c5933bab698d651c324397d7 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-HasComments: No
