Ian Maxon has posted comments on this change. Change subject: [ASTERIXDB-1952][TX][IDX]Log incoming filter vals ......................................................................
Patch Set 10: > > I had actually planned to work on that after this got merged. I > > think this should be fine to merge now, as the main existing > > usecase for this isn't very badly affected by the flaw in upsert > > filer logging. But right now, without this patch, basically > > recovery just doesnt work at all with filters. > > In that case, please just address my comment regarding the word > "log" in Hyracks and file an issue for the upsert case if you > haven't :). I will let Abdullah do his pass as discussed yesterday. Oh whoops I thought I had uploaded those changes already on Friday. It's up now. -- To view, visit https://asterix-gerrit.ics.uci.edu/1798 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9268fe0b60145545c5933bab698d651c324397d7 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Jianfeng Jia <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-HasComments: No
