Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-1964][FUN] Add type conversion functions ......................................................................
Patch Set 2: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1861/2/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml File asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml: PS2, Line 8512: Text > Add some negative tests for the error case? Done https://asterix-gerrit.ics.uci.edu/#/c/1861/2/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md File asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md: PS2, Line 272: > Please fix the end-of-line whitespace. Done https://asterix-gerrit.ics.uci.edu/#/c/1861/2/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ToBigIntDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ToBigIntDescriptor.java: PS2, Line 46: new IFunctionDescriptorFactory() { : @Override : public IFunctionDescriptor createFunctionDescriptor() { : return new ToBigIntDescriptor(); : } > replace these with a function reference Yes, byte-code generation code doesn't handle lambdas -- To view, visit https://asterix-gerrit.ics.uci.edu/1861 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cf119d8a5dd172f4ce2402315fabf7db084559c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes
