Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-1753][SQL] Disable auto-plural for group-by. ......................................................................
Patch Set 6: Code-Review+2 (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1860/6/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppGroupByVisitor.java File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppGroupByVisitor.java: Line 249 Do we have a testcase that got changed because of this change? If not can we add one? Line 223: // Puts all FROM binding variables into withVarList. This comment is no longer valid, right? Can we remove it? -- To view, visit https://asterix-gerrit.ics.uci.edu/1860 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d6383fc7453fe7537fc291c3483708b59df3871 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
