Taewoo Kim has posted comments on this change. Change subject: [WIP][ASTERIXDB-1984][COMP] proper fieldtype propagation ......................................................................
Patch Set 2: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/1880/2/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java: Line 308: if (rightSubTree.hasDataSource()) { > MAJOR SonarQube violation: Done Line 319: if (matchInRightSubTree) { > MAJOR SonarQube violation: Done Line 319: if (matchInRightSubTree) { > BLOCKER SonarQube violation: Done Line 328: if (checkRightSubTreeMetadata) { > BLOCKER SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1880/2/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataManagerUtil.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataManagerUtil.java: Line 123: searchNotNecessaryFromNow = true; > MAJOR SonarQube violation: Done https://asterix-gerrit.ics.uci.edu/#/c/1880/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java: Line 87: Set<String> allPossibleAdditionalFieldNames) { > MAJOR SonarQube violation: Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1880 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-HasComments: Yes
