Murtadha Hubail has submitted this change and it was merged. Change subject: [ASTERIXDB-1982][FAIL] Fix DatasetPartitionWriter fail behavior ......................................................................
[ASTERIXDB-1982][FAIL] Fix DatasetPartitionWriter fail behavior - user model changes: no - storage format changes: no - interface changes: no Details: - Do not write an empty result partition on pipeline failure. Change-Id: I1e065fd7e4204773e17d809b6e44059c709eb27b Reviewed-on: https://asterix-gerrit.ics.uci.edu/1891 Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> BAD: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: Yingyi Bu <[email protected]> --- M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/DatasetPartitionWriter.java 1 file changed, 6 insertions(+), 9 deletions(-) Approvals: Yingyi Bu: Looks good to me, approved Jenkins: Verified; No violations found; No violations found; Verified diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/DatasetPartitionWriter.java b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/DatasetPartitionWriter.java index 81f5551..0189735 100644 --- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/DatasetPartitionWriter.java +++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/dataset/DatasetPartitionWriter.java @@ -98,14 +98,9 @@ @Override public void fail() throws HyracksDataException { - try { - failed = true; - resultState.closeAndDelete(); - resultState.abort(); - registerResultPartitionLocation(false); - } catch (HyracksException e) { - throw new HyracksDataException(e); - } + failed = true; + resultState.closeAndDelete(); + resultState.abort(); } @Override @@ -121,7 +116,9 @@ resultState.close(); } try { - manager.reportPartitionWriteCompletion(jobId, resultSetId, partition); + if (partitionRegistered) { + manager.reportPartitionWriteCompletion(jobId, resultSetId, partition); + } } catch (HyracksException e) { throw new HyracksDataException(e); } -- To view, visit https://asterix-gerrit.ics.uci.edu/1891 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e065fd7e4204773e17d809b6e44059c709eb27b Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]>
