Till Westmann has posted comments on this change. Change subject: Allow logical plan to be viewed as JSON / formatted JSON ......................................................................
Patch Set 1: (6 comments) Most of the formatting issues should be easily resolvable by setting the IDE up as described on the website (http://asterixdb.apache.org/dev-setup.html#setting-up-an-asterix-development-environment) and letting the IDE format the code. https://asterix-gerrit.ics.uci.edu/#/c/1885/1/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java: PS1, Line 51: public New line before the enum and maybe a comment? https://asterix-gerrit.ics.uci.edu/#/c/1885/1/asterixdb/asterix-app/pom.xml File asterixdb/asterix-app/pom.xml: PS1, Line 284: 2.2.3 The asterixdb root pom uses version 2.8.4, we should remove this version and rely on the inherited version.. https://asterix-gerrit.ics.uci.edu/#/c/1885/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java: PS1, Line 36: .*; Please do not use *-includes. Line 41: import org.apache.asterix.lang.common.base.*; Please do not use *-includes. PS1, Line 81: import java.io.IOException; : import java.io.PrintWriter; : import java.rmi.RemoteException; : import java.util.*; Please don't reorder the includes. https://asterix-gerrit.ics.uci.edu/#/c/1885/1/hyracks-fullstack/algebricks/algebricks-examples/piglet-example/src/main/java/org/apache/hyracks/algebricks/examples/piglet/compiler/PigletCompiler.java File hyracks-fullstack/algebricks/algebricks-examples/piglet-example/src/main/java/org/apache/hyracks/algebricks/examples/piglet/compiler/PigletCompiler.java: PS1, Line 19: package There seem to be no changes in this file. Can we revert this file? -- To view, visit https://asterix-gerrit.ics.uci.edu/1885 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: [email protected] Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
