Dmitry Lychagin has posted comments on this change.

Change subject: [DOC] Reorganize data model documentations.
......................................................................


Patch Set 2:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1898/2/asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_primitive_common.md
File 
asterixdb/asterix-doc/src/main/markdown/datamodel/datamodel_primitive_common.md:

Line 51: - `tinyint`: -127 to 127
min value for tinyint should be -128, right? 
same comment for 'smallint' and 'integer'


Line 73:         { "v1": float("NaN"), "v2": float("INF"), "v3": float("-INF"), 
"v4": float("-2013.5") };
do we parse 'INF' or 'Infinity' or both? This example might be confusing to 
users because we parse 'INF', but output 'Infinity'


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1898
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a2306747631c25d46c5246643abc1e147cf7c21
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <[email protected]>
Gerrit-Reviewer: Dmitry Lychagin <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-HasComments: Yes

Reply via email to