Till Westmann has posted comments on this change. Change subject: [UI,SITE] Allow logical plan to be viewed as JSON / formatted JSON ......................................................................
Patch Set 9: (13 comments) https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java: Line 45: public enum OutputFormat { It seems that this is not formatted according to our project rules: https://cwiki.apache.org/confluence/display/ASTERIXDB/Formatting The goal in having a consistent set of rules for formatting is to avoid differences that only change formatting. This reduces the number of changes in a file and thus reduces the effort of reviewing changes for everybody. So please try to minimize formatting changes. The easiest way to do that is to use the Eclipse formatting rules linked above either directly in Eclipse or by using the "Eclipse Code Formatter" plugin in IDEA (just importing the format into standard IDEA won't work unfortunately). https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/pom.xml File asterixdb/asterix-app/pom.xml: PS9, Line 284: <version>2.8.4</version> We should provide a version here, as the version is provided in the asterixdb/pom.xml . https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java: PS9, Line 117: private Please check the formatting here. https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java: PS9, Line 178: IStatementExecutor Please check the formatting here. PS9, Line 197: protected Please check the formatting here. https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java: PS9, Line 256: TODO Could you file an issue for this? https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java: PS9, Line 112: format Please check the formatting in this file. https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java: PS9, Line 113: IStatementExecutor Please check the formatting in this file. https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/main/resources/webui/static/css/style.css File asterixdb/asterix-app/src/main/resources/webui/static/css/style.css: PS9, Line 260: Please remove this end-of-line whitespace. https://asterix-gerrit.ics.uci.edu/#/c/1885/9/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonLogicalPlanTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonLogicalPlanTest.java: PS9, Line 61: > Seems like this is more or less the same as its optimized counterpart sans +1 https://asterix-gerrit.ics.uci.edu/#/c/1885/9/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java: PS9, Line 50: UNPARTITIONED Please check the formatting in this file. https://asterix-gerrit.ics.uci.edu/#/c/1885/9/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/plan/ALogicalPlanImpl.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/plan/ALogicalPlanImpl.java: PS9, Line 28: import As there are no functional changes is this file, it should be reverted to its original state. https://asterix-gerrit.ics.uci.edu/#/c/1885/9/hyracks-fullstack/algebricks/algebricks-examples/piglet-example/src/main/java/org/apache/hyracks/algebricks/examples/piglet/compiler/PigletCompiler.java File hyracks-fullstack/algebricks/algebricks-examples/piglet-example/src/main/java/org/apache/hyracks/algebricks/examples/piglet/compiler/PigletCompiler.java: PS9, Line 35: org This file should be reverted as well. -- To view, visit https://asterix-gerrit.ics.uci.edu/1885 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: shi...@uci.edu Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
