Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2047][UI] Escape special entities in HTML result delivery ......................................................................
Patch Set 6: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1949/6/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultPrinter.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/result/ResultPrinter.java: PS6, Line 181: record = ResultUtil.escapeHTML(record); Should this happen before or after quoting and escaping characters in theJSON? It seems that - as this quoting and escaping is part of the results serialization and the escaping of HTML entities is part of the presentation in the browser - the JSON quoting should happen first. But I haven't thought about this too deeply ... -- To view, visit https://asterix-gerrit.ics.uci.edu/1949 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7aa05fe39b7a1f755574c4f49fd9694239078586 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
