Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-1812][RT] Budget the memory usage for pre-clustered group-by. ......................................................................
Patch Set 12: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1940/12/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SetAlgebricksPhysicalOperatorsRule.java: Line 190: op.setPhysicalOperator(new PreclusteredGroupByPOperator(columnList, gby.isGroupAll(), rename to getMaxFramesGroupBy() https://asterix-gerrit.ics.uci.edu/#/c/1940/12/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java File hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java: Line 151: if (memoryBudget > 0 && data.length > memoryBudget) { move if (memoryBugdet>0) up 2 lines https://asterix-gerrit.ics.uci.edu/#/c/1940/12/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/group/preclustered/PreclusteredGroupWriter.java: Line 83: this.memoryLimit = ((long) (framesLimit - 2)) * ctx.getInitialFrameSize(); // Deducts input/output frames. set to -1 if framesLimit is -1 -- To view, visit https://asterix-gerrit.ics.uci.edu/1940 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I670269b0b8f446d06d8dd73202194574aa524e85 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <buyin...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: Yes
