Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2058][HYR] Only Complete job cancellation after cleanup ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1961/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/NCQueryServiceServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/NCQueryServiceServlet.java: Line 133: protected SessionOutput createSessionOutput(RequestParameters param, String handleUrl, PrintWriter resultWriter) { We need to refactor this method. Currently too much copy/paste from the superclasss. May be introduce a separate createSessionConfig() method, or just make SessionConfig fields mutable, so this one can just set the timeout on the SessionConfig created by the superclass Line 141: new SessionConfig(format, true, true, true, ExecuteStatementRequestMessage.DEFAULT_JOB_TIMEOUT_MILLIS); We wanted to get job timeout from 'timeout' request parameter, like n1ql does, instead of hardcoding it here. See https://developer.couchbase.com/documentation/server/current/n1ql/n1ql-rest-api/index.html So user can override it that way for long-running queries. -- To view, visit https://asterix-gerrit.ics.uci.edu/1961 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14b4bbd512cc88e489254d8bf82edba0fd3a3db5 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Michael Carey <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
