Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-2064][ING] Timeout Stop Feed ......................................................................
Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1964/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java: PS1, Line 221: long sofar = now - start; : long remaining = timeout - sofar; can't we replace start, now, sofar, and remaining with a single long representing the timeout time, and avoid all these updates? e.g. end = System.currentTimeMillis() + timeout;, then compare that to System.currentTimeMillis() to determine when to break? https://asterix-gerrit.ics.uci.edu/#/c/1964/1/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorNodePushable.java: PS1, Line 126: 10000 introduce constant? should this be configurable (in the future)? -- To view, visit https://asterix-gerrit.ics.uci.edu/1964 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If609a8343767ee7a80689a58af35a1b3fca2964b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-HasComments: Yes
