Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2058][HYR] Only Complete job cancellation after cleanup ......................................................................
Patch Set 5: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1961/11/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java: PS11, Line 202: tement", JSONUtil.escape(n I think that we should move this to a separate class Duration (in the same package?). Seems to a a lot of code that is not very specific to this servlet (and the parsing is indeed about durations ..). https://asterix-gerrit.ics.uci.edu/#/c/1961/11/asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/ParseDurationTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/runtime/ParseDurationTest.java: PS11, Line 32: If we call this Duration, the name TimUnit won't be ambiguous and all of this is probably a lot more readable ... -- To view, visit https://asterix-gerrit.ics.uci.edu/1961 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I14b4bbd512cc88e489254d8bf82edba0fd3a3db5 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Michael Carey <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
