Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-2076][TEST] Fix encoding issue in HyracksVirtualCluster ......................................................................
Patch Set 2: Code-Review-1 (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1982/2//COMMIT_MSG Commit Message: PS2, Line 7: [TEST] Seems like the wrong component when all changes are to product code https://asterix-gerrit.ics.uci.edu/#/c/1982/2/hyracks-fullstack/hyracks/hyracks-server/src/main/java/org/apache/hyracks/server/process/HyracksCCProcess.java File hyracks-fullstack/hyracks/hyracks-server/src/main/java/org/apache/hyracks/server/process/HyracksCCProcess.java: PS2, Line 45: // Make sure CC talks in UTF-8 : cList.add("-Dfile.encoding=" + StandardCharsets.UTF_8); I think this is the wrong fix- whatever is reading / writing should be specifying UTF-8 and not relying on the default encoding. https://asterix-gerrit.ics.uci.edu/#/c/1982/2/hyracks-fullstack/hyracks/hyracks-server/src/main/java/org/apache/hyracks/server/process/HyracksNCServiceProcess.java File hyracks-fullstack/hyracks/hyracks-server/src/main/java/org/apache/hyracks/server/process/HyracksNCServiceProcess.java: PS2, Line 45: cList.add("-Dfile.encoding=" + StandardCharsets.UTF_8); I think this is the wrong fix- whatever is reading / writing should be specifying UTF-8 and not relying on the default encoding. -- To view, visit https://asterix-gerrit.ics.uci.edu/1982 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a09b7aca59e289d2f9593a3ddcf6e98802ebc8d Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
