Xikui Wang has posted comments on this change.

Change subject: [ASTERIXDB-2075][HYR] Add disk free space to Heartbeat using df
......................................................................


Patch Set 4:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1967/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/profiling/DiskFreeSizeCalculatorFactory.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/profiling/DiskFreeSizeCalculatorFactory.java:

Line 40: class DFDiskFreeSpaceCalculator implements IDiskFreeSpaceCalculator {
> Why couldn't we use Java's FileStore API get free disk space?https://docs.o
Didn't know we could use this one... I'm wondering whether this is synchronous 
call as well? Also, it seems this cannot deal with IODevices on the same disk?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1967
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia52f1b0867227446b0c5bee95ea4abdfb451064a
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Michael Blow <[email protected]>
Gerrit-Reviewer: Xikui Wang <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to