Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][OTH] Improve Http Server ......................................................................
Patch Set 2: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/1991/2/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java: PS2, Line 112: buffer = null; Add a comment here to why this is needed https://asterix-gerrit.ics.uci.edu/#/c/1991/2/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java: PS2, Line 104: inputBudgetEstimate << 1; really? :) PS2, Line 106: \"estimated\" Does it really have to be "estimated"? :) PS2, Line 107: LOGGER.log(Level.INFO, "Multiple arenas, memory fragments, and local thread cached buffers " : + "can cause the input memory usage to exceed estimate"); : LOGGER.log(Level.INFO, "Custom Buffer allocator must be used to avoid this"); Replace this by a comment PS2, Line 300: printMemUsage Move to a util class https://asterix-gerrit.ics.uci.edu/#/c/1991/2/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerInitializer.java File hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServerInitializer.java: PS2, Line 65: else { Remove else -- To view, visit https://asterix-gerrit.ics.uci.edu/1991 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7adcd59047805dc384e1c119191eff995c6e9a7a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-HasComments: Yes
