Murtadha Hubail has posted comments on this change. Change subject: [ASTERIXDB-2050][SQL] Update Docs to Reflect New SQL++ Model ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1996/1/asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md File asterixdb/asterix-doc/src/main/markdown/sqlpp/appendix_2_parameters.md: PS1, Line 22: <STRING_LITERAL> > Have semi-colon after this? I believe this should be implicit since the new syntax of Statement enforces ";" after every SingleStatement. Since SetStatement is a SingleStatement, maybe we shouldn't add ";" here. Otherwise we will have to update all statements in the docs and end them with ";". What do you think? -- To view, visit https://asterix-gerrit.ics.uci.edu/1996 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31ed7413a6de028fa9d1a0a9d2c6b36ac39ff9c9 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
