Till Westmann has posted comments on this change. Change subject: [NO ISSUE][HYR][*DB][CLUS] Startup lifecycle fixes ......................................................................
Patch Set 3: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2004/3/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IClusterManagementWork.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/api/IClusterManagementWork.java: PS3, Line 31: RECOVERING What's the difference between PENDING and RECOVERING? Maybe we could add comments to each state to clarify? https://asterix-gerrit.ics.uci.edu/#/c/2004/3/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/IApplication.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/application/IApplication.java: PS3, Line 28: fixupThreadFactory This method does not seem to fit in well with the other ones. Why is the ThreadFactory a top-level application concern? -- To view, visit https://asterix-gerrit.ics.uci.edu/2004 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id30415325047008c013e305ca11ccbb76bc7d8d8 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
