Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required ......................................................................
Patch Set 17: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/1880/17/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java: Line 328: e.printStackTrace(); > CRITICAL SonarQube violation: Same. Why exception is caught and swallowed here? Line 335: e.printStackTrace(); > CRITICAL SonarQube violation: Same. Why exception is caught and swallowed here? Line 413: boolean leftSubTreeInitialized = leftSubTree.initFromSubTree(joinOp.getInputs().get(0), false); leftSubTreeInitialized is not needed and should probably be removed because we're not initializing the left subtree Line 421: if (leftSubTree.hasDataSourceScan() || rightSubTree.hasDataSourceScan()) { Can we remove leftSubTree.hasDataSourceScan() , because The left subtree was not initialized? https://asterix-gerrit.ics.uci.edu/#/c/1880/17/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java: Line 343: } catch (Exception e) { > CRITICAL SonarQube violation: What kind of exception is caught here and why is it swallowed? It didn't do it previously. https://asterix-gerrit.ics.uci.edu/#/c/1880/17/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java: Line 103: return true; Should this return 'false' because the subtree was not fully initialized? Returning 'true' implies that a datasource was found which could not possibly happen if parameter 'initDataSource' was set to 'false' -- To view, visit https://asterix-gerrit.ics.uci.edu/1880 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25 Gerrit-PatchSet: 17 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
