Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index ......................................................................
Patch Set 14: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1916/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Index.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Index.java: Line 146: if (isPrimaryIndex || indexDataset.getDatasetType() == DatasetConfig.DatasetType.EXTERNAL || > Yes, we could put checks in "QueryTranslator.handleCreateIndexStatement" to Sounds good. Let's do it https://asterix-gerrit.ics.uci.edu/#/c/1916/14/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/FixReplicateOperatorOutputsRule.java File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/FixReplicateOperatorOutputsRule.java: Line 123: if (parentsPathToReplicate.contains(replicateOperator.getOutputs().get(oldParentIndex))) { > Yes, when replicate/split operators hold references to their outputs (i.e. yes, deleting and then assigning real parents would be better. As for 'outputMaterializationFlags', may be for now we just have one boolean which would apply to all outputs. So the order in which we reassign outputs would not matter. Eventually we should explore whether we can move that 'materialization' property from the logical to the physical level, and see whether it could be inferred automatically based on the topology of the physical plan. I've filed ASTERIXDB-2099 to track future work in this area. -- To view, visit https://asterix-gerrit.ics.uci.edu/1916 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59725425ba7c5fe438507dc900f83eaab239d296 Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Carey <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
