Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2078][SQL] DISTINCT modifier for aggregate functions ......................................................................
Patch Set 6: Code-Review+2 (1 comment) We should also have some docs - in a separate change. https://asterix-gerrit.ics.uci.edu/#/c/1987/6/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppDistinctAggregationSugarVisitor.java File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/SqlppDistinctAggregationSugarVisitor.java: PS6, Line 52: AbstractSqlppExpressionScopingVisitor Do we need this? -- To view, visit https://asterix-gerrit.ics.uci.edu/1987 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52772349cbcbfc68a3a1ff261d610871ca38748d Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
