Wail Alkowaileet has posted comments on this change.

Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup
......................................................................


Patch Set 17:

(1 comment)

Great work Illdar!
I have only one question about IChainedComponentBulkLoader (inlined).
AFAIK, the LSM Stats Collector lives in the hyracks level. Som I'm not sure if 
the Stat Collector requires similar approach.

https://asterix-gerrit.ics.uci.edu/#/c/2014/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/IChainedComponentBulkLoader.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/IChainedComponentBulkLoader.java:

PS17, Line 26: IChainedComponentBulkLoader
AsterixDB Tuple Compactor works in AsterixDB level.
So what I probably need is a (serializable) factory for the 
IChainedComponentBulkLoader. The configuration of the bulkload task will be 
determined per dataset basis. In other words, It depends on the initial 
type/schema of the dataset and if the tuple compactor is enabled.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2014
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ildar Absalyamov <[email protected]>
Gerrit-Reviewer: Ian Maxon <[email protected]>
Gerrit-Reviewer: Ildar Absalyamov <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Luo Chen <[email protected]>
Gerrit-Reviewer: Wail Alkowaileet <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to