Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][CLUS] Unexport Metadata Node Stub on NC Stop ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2027/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/NCAppRuntimeContext.java: PS1, Line 470: public void > make this synchronized or are we sure it will only be called from a single Currently it is only one thread (NC Startup Tasks executor and shutdown hook), but when replication is enabled and a metadata node failover is performed, it is possible if messages arrived in an unexpected order. I made export/unexport/preStop synchronized to account for that. -- To view, visit https://asterix-gerrit.ics.uci.edu/2027 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7f1b7a294968e871465900b04c05cf388b776e4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
