abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE][STO] Component Rollback Through flushes and merges ......................................................................
Patch Set 9: (11 comments) comments by Till and Murtadha... https://asterix-gerrit.ics.uci.edu/#/c/2017/9/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTree.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTree.java: PS9, Line 468: component.validate rename. https://asterix-gerrit.ics.uci.edu/#/c/2017/9/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponent.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponent.java: PS9, Line 70: public FileReference getFile() make sure is needed https://asterix-gerrit.ics.uci.edu/#/c/2017/9/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMDiskComponent.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMDiskComponent.java: PS9, Line 66: validate rename https://asterix-gerrit.ics.uci.edu/#/c/2017/9/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIndexAccessor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIndexAccessor.java: PS9, Line 261: void rollback(Predicate<ILSMComponent> predicate) throws HyracksDataException; add the assumption that the dmls are stopped https://asterix-gerrit.ics.uci.edu/#/c/2017/9/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java: PS9, Line 308: ROLLBACK rename PS9, Line 395: public static void markAsValidInternal(ITreeIndex treeIndex, boolean forceToDisk) throws HyracksDataException { : int fileId = treeIndex.getFileId(); : IBufferCache bufferCache = treeIndex.getBufferCache(); : treeIndex.getPageManager().close(); : // WARNING: flushing the metadata page should be done after releasing the write latch; otherwise, the page : // won't be flushed to disk because it won't be dirty until the write latch has been released. : // Force modified metadata page to disk. : // If the index is not durable, then the flush is not necessary. : if (forceToDisk) { : bufferCache.force(fileId, true); : } : } : : public static void markAsValidInternal(IBufferCache bufferCache, BloomFilter filter, boolean forceToDisk) : throws HyracksDataException { : if (forceToDisk) { : bufferCache.force(filter.getFileId(), true); : } : } move to a util class... PS9, Line 687: List<ILSMComponent> mergingComponents no need to pass this anymore. https://asterix-gerrit.ics.uci.edu/#/c/2017/9/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java: PS9, Line 756: boolean canRollback = true; put canRollback in a separate method PS9, Line 766: memComponent DiskComponent Line 809: ctx.reset(); acquire again... wait for all merges to finish again... PS9, Line 826: ioCallback.waitForIO(); file an issue about waitForIO to report success vs failure. -- To view, visit https://asterix-gerrit.ics.uci.edu/2017 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I178656207bfa1d15e6ae5ff2403a16df33940773 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
