Michael Blow has posted comments on this change. Change subject: [NO ISSUE] Add support for tracing ......................................................................
Patch Set 19: Code-Review+2 (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2022/19/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/Tracer.java File hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/trace/Tracer.java: PS19, Line 70: return new Tracer("None", new String[0]) why not share a static no-op tracer? PS19, Line 74: return new Tracer("All", new String[] { "*" }); why not share a static * tracer? -- To view, visit https://asterix-gerrit.ics.uci.edu/2022 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa83592870e7e38a84aa560e4edb7fa2ad2d5e74 Gerrit-PatchSet: 19 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
