Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required ......................................................................
Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2030/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java: Line 606: Pair<ILogicalOperator, Set<LogicalVariable>> RootOpAndPKVars = It looks like there're no testcases in this review for changes in InvertedIndexAccessMethod. Can we move InvertedIndexAccessMethod changes into a separate review and add new tests for them there? The remaining changes (in IntroduceJoinAccessMethodRule) look good and can be merged. -- To view, visit https://asterix-gerrit.ics.uci.edu/2030 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <wangs...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Yingyi Bu <ying...@google.com> Gerrit-HasComments: Yes
