Murtadha Hubail has posted comments on this change. Change subject: [ASTERIXDB-2108][API][RT] Add Processed Objects Metric ......................................................................
Patch Set 5: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/2032/5/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/IStatementExecutor.java: PS5, Line 65: processedObjects > I think that it'd be nicer to add Stats to the ExecuteStatementResponseMess I know, I just wanted it to come from you :) https://asterix-gerrit.ics.uci.edu/#/c/2032/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCQueryServiceServlet.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/NCQueryServiceServlet.java: PS5, Line 123: stats > This could be Done and moved outside of the loop. https://asterix-gerrit.ics.uci.edu/#/c/2032/5/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java: PS5, Line 2398: , ResultMetadata outMetadata > Not needed? Done PS5, Line 2415: if (outMetadata != null) { : outMetadata.setProcessedObjects(processedObjects); : } > Not needed? Done https://asterix-gerrit.ics.uci.edu/#/c/2032/5/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java: PS5, Line 892: METRICS_QUERY_TYPE > Stick with the convention in the file and use a literal here? Done PS5, Line 1208: reqType.equals(METRICS_QUERY_TYPE) > This smells like it should be a conditional expression. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2032 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4afe6a676ef0b8a31d36d7dafc13a4023ebf177 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
