abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE][STO][IDX] LSM storage cleanup ......................................................................
Patch Set 20: (9 comments) https://asterix-gerrit.ics.uci.edu/#/c/2014/20/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryIndexBulkLoadNodePushable.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMSecondaryIndexBulkLoadNodePushable.java: PS20, Line 203: createComponentBulkLoader change from createComponentBulkLoader to createBulkLoader PS20, Line 204: secondaryIndex.needBloomFilter(numTuples) The component should know if it needs bloomFilter when it is created (line 201). There should be no need to consult the index object again. https://asterix-gerrit.ics.uci.edu/#/c/2014/20/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTree.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTree.java: PS20, Line 270: activateDiskComponent it is a disk component, so rename to simply activete() PS20, Line 298: purgeDiskComponent purge() PS20, Line 319: clearDiskComponent rename to clear() PS20, Line 338: destroyDiskComponent rename to destroy() https://asterix-gerrit.ics.uci.edu/#/c/2014/20/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponent.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponent.java: PS20, Line 39: public BTree getIndex() { : return btree; : } : : public BTree getTreeIndex() { : return btree; : } Why two methods doing the exact same thing? https://asterix-gerrit.ics.uci.edu/#/c/2014/20/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeMemoryComponent.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeMemoryComponent.java: PS20, Line 46: ILSMMemoryComponent.super.resetMemoryComponent(); interesting... https://asterix-gerrit.ics.uci.edu/#/c/2014/20/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/utils/LSMBTreeUtil.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/utils/LSMBTreeUtil.java: PS20, Line 113: if (needKeyDupCheck) { : BloomFilterFactory bloomFilterFactory = new BloomFilterFactory(diskBufferCache, bloomFilterKeyFields); : componentFactory = : new LSMBTreeWithBloomFilterDiskComponentFactory(diskBTreeFactory, bloomFilterFactory, filterHelper); : bulkLoadComponentFactory = new LSMBTreeWithBloomFilterDiskComponentFactory(bulkLoadBTreeFactory, : bloomFilterFactory, filterHelper); : } else { : componentFactory = new LSMBTreeDiskComponentFactory(diskBTreeFactory, filterHelper); : bulkLoadComponentFactory = new LSMBTreeDiskComponentFactory(bulkLoadBTreeFactory, filterHelper); : } This is not using the util method that was just created... -- To view, visit https://asterix-gerrit.ics.uci.edu/2014 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e Gerrit-PatchSet: 20 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
