Till Westmann has posted comments on this change. Change subject: [NO ISSUE][OTH] Trace Scheduling of IO operations ......................................................................
Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2039/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java: PS1, Line 340: instant This is always traced - independent of the fact if the tracer is enabled. I'm wondering if we could/should move this inside of the TracedIOOperation.wrap as this would then be enabled/disabled by the same check that introduced the wrapper (or not). Thoughts? PS1, Line 340: Scope.p Is this a process-scoped operation or per iodevice? -- To view, visit https://asterix-gerrit.ics.uci.edu/2039 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5146d41de2ea4b46c53ce33ce467b8304bce177 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
