Michael Blow has posted comments on this change. Change subject: [NO ISSUE] Add performance traces for frame writes ......................................................................
Patch Set 2: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/2047/2/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java: PS2, Line 131: CAN_NOT CANNOT https://asterix-gerrit.ics.uci.edu/#/c/2047/2/hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties File hyracks-fullstack/hyracks/hyracks-api/src/main/resources/errormsg/en.properties: PS2, Line 114: did not cannot? https://asterix-gerrit.ics.uci.edu/#/c/2047/2/hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/util/FrameUtils.java File hyracks-fullstack/hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/util/FrameUtils.java: PS2, Line 159: tracer != null && tracer.isEnabled() We need to fix this contract soon- let's have a no-op tracer to avoid checking for null everywhere... (error prone and ugly) PS2, Line 247: 4 is this / can this be a constant somewhere? PS2, Line 271: 4 is this / can this be a constant somewhere? -- To view, visit https://asterix-gerrit.ics.uci.edu/2047 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib32f4122fdddff1d0dce282a99829e0e0ad820e9 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
