Steven Jacobs has posted comments on this change. Change subject: [ASTERIXDB-2089][HYR,RT,CLUS] Fixes and Improvements for predistributed Jobs ......................................................................
Patch Set 4: (4 comments) Addressed Comments https://asterix-gerrit.ics.uci.edu/#/c/2045/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveRedundantSelectRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/RemoveRedundantSelectRule.java: Line 75: private boolean alwaysHold(ILogicalExpression cond, IOptimizationContext context) { > MAJOR SonarQube violation: Done PS4, Line 87: cond.getExpressionTag() == LogicalExpressionTag.FUNCTION_CALL > This seems to be a narrow solution, as it covers exactly one shape of the p Done https://asterix-gerrit.ics.uci.edu/#/c/2045/4/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceFunctions.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceFunctions.java: PS4, Line 153: predestributedId > What is a predistributedId? A Jobid identifies a job, what does a predistri This enables us to eventually allow for simultaneous execution of one predistributed job, e.g. multiple users running the same procedure. In order to accommodate this, the predistributed job needs to have a unique identifier that is different from the JobId (which will be different for each simultaneous run, allowing concurrency). https://asterix-gerrit.ics.uci.edu/#/c/2045/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java: Line 430: if (jpbs == null){ > MAJOR SonarQube violation: Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2045 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f493c1fa977d07dfe8a875f9ebe9515d01d1473 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
