Murtadha Hubail has submitted this change and it was merged. Change subject: [NO ISSUE] Pass Request Parameters to DDLs ......................................................................
[NO ISSUE] Pass Request Parameters to DDLs - user model changes: no - storage format changes: no - interface changes: no Details: - Pass RequestParameters to create/drop dataset/index to allow QueryTranslator extensions to consume them. Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Reviewed-on: https://asterix-gerrit.ics.uci.edu/2053 Integration-Tests: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Tested-by: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Reviewed-by: Till Westmann <ti...@apache.org> --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Till Westmann: Looks good to me, approved Jenkins: Verified; Verified Objections: Anon. E. Moose #1000171: Jenkins: Violations found; diff --git a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java index 454b501..6b4483c 100644 --- a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java +++ b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/translator/QueryTranslator.java @@ -300,10 +300,10 @@ handleCreateDataverseStatement(metadataProvider, stmt); break; case Statement.Kind.DATASET_DECL: - handleCreateDatasetStatement(metadataProvider, stmt, hcc); + handleCreateDatasetStatement(metadataProvider, stmt, hcc, requestParameters); break; case Statement.Kind.CREATE_INDEX: - handleCreateIndexStatement(metadataProvider, stmt, hcc); + handleCreateIndexStatement(metadataProvider, stmt, hcc, requestParameters); break; case Statement.Kind.TYPE_DECL: handleCreateTypeStatement(metadataProvider, stmt); @@ -315,10 +315,10 @@ handleDataverseDropStatement(metadataProvider, stmt, hcc); break; case Statement.Kind.DATASET_DROP: - handleDatasetDropStatement(metadataProvider, stmt, hcc); + handleDatasetDropStatement(metadataProvider, stmt, hcc, requestParameters); break; case Statement.Kind.INDEX_DROP: - handleIndexDropStatement(metadataProvider, stmt, hcc); + handleIndexDropStatement(metadataProvider, stmt, hcc, requestParameters); break; case Statement.Kind.TYPE_DROP: handleTypeDropStatement(metadataProvider, stmt); @@ -512,7 +512,7 @@ } public void handleCreateDatasetStatement(MetadataProvider metadataProvider, Statement stmt, - IHyracksClientConnection hcc) throws CompilationException, Exception { + IHyracksClientConnection hcc, IRequestParameters requestParameters) throws CompilationException, Exception { MutableObject<ProgressState> progress = new MutableObject<>(ProgressState.NO_PROGRESS); DatasetDecl dd = (DatasetDecl) stmt; String dataverseName = getActiveDataverse(dd.getDataverse()); @@ -741,7 +741,7 @@ } protected void handleCreateIndexStatement(MetadataProvider metadataProvider, Statement stmt, - IHyracksClientConnection hcc) throws Exception { + IHyracksClientConnection hcc, IRequestParameters requestParameters) throws Exception { CreateIndexStatement stmtCreateIndex = (CreateIndexStatement) stmt; String dataverseName = getActiveDataverse(stmtCreateIndex.getDataverseName()); String datasetName = stmtCreateIndex.getDatasetName().getValue(); @@ -1338,7 +1338,7 @@ } public void handleDatasetDropStatement(MetadataProvider metadataProvider, Statement stmt, - IHyracksClientConnection hcc) throws Exception { + IHyracksClientConnection hcc, IRequestParameters requestParameters) throws Exception { DropDatasetStatement stmtDelete = (DropDatasetStatement) stmt; String dataverseName = getActiveDataverse(stmtDelete.getDataverseName()); String datasetName = stmtDelete.getDatasetName().getValue(); @@ -1409,7 +1409,7 @@ } protected void handleIndexDropStatement(MetadataProvider metadataProvider, Statement stmt, - IHyracksClientConnection hcc) throws Exception { + IHyracksClientConnection hcc, IRequestParameters requestParameters) throws Exception { IndexDropStatement stmtIndexDrop = (IndexDropStatement) stmt; String datasetName = stmtIndexDrop.getDatasetName().getValue(); @@ -2850,7 +2850,7 @@ // Cleans up the sink dataset -- Drop and then Create. DropDatasetStatement dropStmt = new DropDatasetStatement(new Identifier(dataverseNameTo), pregelixStmt.getDatasetNameTo(), true); - this.handleDatasetDropStatement(metadataProvider, dropStmt, hcc); + this.handleDatasetDropStatement(metadataProvider, dropStmt, hcc, null); IDatasetDetailsDecl idd = new InternalDetailsDecl(toIndex.getKeyFieldNames(), toIndex.getKeyFieldSourceIndicators(), false, null, toDataset.getDatasetDetails().isTemp()); DatasetDecl createToDataset = new DatasetDecl(new Identifier(dataverseNameTo), @@ -2860,7 +2860,7 @@ new Identifier(toDataset.getMetaItemTypeName()), new Identifier(toDataset.getNodeGroupName()), toDataset.getCompactionPolicy(), toDataset.getCompactionPolicyProperties(), toDataset.getHints(), toDataset.getDatasetType(), idd, false); - this.handleCreateDatasetStatement(metadataProvider, createToDataset, hcc); + this.handleCreateDatasetStatement(metadataProvider, createToDataset, hcc, null); } catch (Exception e) { LOGGER.log(Level.WARNING, e.getMessage(), e); throw new AlgebricksException("Error cleaning the result dataset. This should not happen."); -- To view, visit https://asterix-gerrit.ics.uci.edu/2053 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I044e97d001fc42caa137de0a89fb27c47a88ef3c Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org>
