Luo Chen has posted comments on this change. Change subject: [ASTERIXDB-2121][HYR] Handle Throwables during job execution ......................................................................
Patch Set 2: > It is undesired to catch non-Exceptions, as they can be critical VM > conditions (such as out of memory). Uncaught exceptions should be > handled by the uncaught exception handler, which attempts to log > the exception and shutdown the process. Hi Mike, could you take a look at this new patch by adding some logging to uncaught throwables? I believe it's useful for both testing and debugging purposes to do so. If not, I'll discard this patch... -- To view, visit https://asterix-gerrit.ics.uci.edu/2051 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbe09d5231fe2bdfa12d834bb1a6adb46b355a48 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-HasComments: No
