Xikui Wang has posted comments on this change. Change subject: [HYR,RT,CLUS] Fixes and Improvements for predistributed Jobs ......................................................................
Patch Set 8: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2045/6//COMMIT_MSG Commit Message: Line 12: Allow predistributed jobs to have a new jobId for each execution > Not sure exactly what you mean here. Maybe we can talk on Skype about this? If this patch is not intended for running multiple instances of the same pjob at the same, this would not be an issue. https://asterix-gerrit.ics.uci.edu/#/c/2045/6/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClientInterfaceIPCI.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClientInterfaceIPCI.java: Line 56: private long predistributedId = 0; > What is the disadvantage of doing it this way? What if someone accidentally reset it or reassigned it somewhere, it would be hard to trace and harder to maintain with many devs. Keep things packed and leave limited interfaces for necessary use cases is a good thing in OOP IMO. -- To view, visit https://asterix-gerrit.ics.uci.edu/2045 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f493c1fa977d07dfe8a875f9ebe9515d01d1473 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
