Murtadha Hubail has posted comments on this change.

Change subject: [ASTERIXDB-2131][TX] Do Not Reset Active Ops For Aborted 
Metadata Txn
......................................................................


Patch Set 1:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2071/1/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java
File 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/metadata/MetadataTxnTest.java:

PS1, Line 61: abortMetadataTxn
> This test is not checking whether the node group was added or not.
Done


PS1, Line 114: / ensure original dataset can be dropped after rebalance failure
> also check the node group associated with the dataset?
We drop the node group by default if all datasets created on it are dropped. I 
added the check that the node group was dropped too.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2071
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee47aca1be0675b704ed9f176d9e10daef1cfc7f
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Murtadha Hubail <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: abdullah alamoudi <[email protected]>
Gerrit-HasComments: Yes

Reply via email to