Murtadha Hubail has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2073
Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in
ByteArrayAccessibleOutputStream
......................................................................
[NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessibleOutputStream
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Remove the hardcoded 64MB memory limit from
ByteArrayAccessibleOutputStream as the limit
shouldn't be controlled by this structure but
rather by operators using it.
Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
---
M
hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
1 file changed, 2 insertions(+), 6 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/73/2073/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
b/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
index bf0e1dd..0f39a90 100644
---
a/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
+++
b/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java
@@ -23,8 +23,7 @@
public class ByteArrayAccessibleOutputStream extends ByteArrayOutputStream {
- private static final int MAX_SIZE = 1024 * 1024 * 32;
- private static final double BUFFER_INCREMENT_FACTOR = 1.5;
+ private static final float BUFFER_INCREMENT_FACTOR = 1.5f;
public ByteArrayAccessibleOutputStream() {
super();
@@ -97,10 +96,7 @@
private void grow(int minCapacity) {
// overflow-conscious code
int oldCapacity = buf.length;
- if (oldCapacity == MAX_SIZE) {
- throw new IllegalArgumentException("Buffer is too large...");
- }
- int newCapacity = Math.min((int) (oldCapacity *
BUFFER_INCREMENT_FACTOR), MAX_SIZE);
+ int newCapacity = (int) (oldCapacity * BUFFER_INCREMENT_FACTOR);
if (newCapacity - minCapacity < 0) {
newCapacity = minCapacity;
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/2073
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <[email protected]>
