Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][RT] Remove Hard Memory Limit in ByteArrayAccessibleOutputStream ......................................................................
Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2073/2/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java File hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/util/ByteArrayAccessibleOutputStream.java: PS2, Line 112: OutOfMemoryError > I'm not sure that we should throw Java's OOM here as that indicates that th That does make sense. Since we are extending ByteArrayOutputStream and its write methods don't throw checked exceptions, I changed this to a RuntimeException with a custom message so one wouldn't get the indication that the JVM is OOM. -- To view, visit https://asterix-gerrit.ics.uci.edu/2073 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia88861c44802e64dbfceb5e8efc75d28bd54b501 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
