Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][STO] Ensure IFrameTupleProcessor Finish is Called ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2083/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java: PS1, Line 684: processor > But if processFrame throws, then processor.finish() won't be called. I believe you are referring to Abdullah's comment. I discussed it with him and raised the same concern as yours and we agreed to keep the initial change the way it is and just log the exception to ensure that it won't be lost due to propagation. -- To view, visit https://asterix-gerrit.ics.uci.edu/2083 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5f4188fa3de3c91f5f6aae95716db016a315ddd6 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
