abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2128] Fix bloomfilter during index search ......................................................................
Patch Set 6: (3 comments) Looks very good. minor comments https://asterix-gerrit.ics.uci.edu/#/c/2069/6//COMMIT_MSG Commit Message: PS6, Line 19: - Compute murmur hashing during bloom filter check is expensive. : Since bloom filters of disk components of an index share the same hash : values for a tuple, this patch also separate compute hash from bloom : filter check to speed up performance not fixed yet? remove and add when fixed? https://asterix-gerrit.ics.uci.edu/#/c/2069/6/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexRangeSearchCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexRangeSearchCursor.java: PS6, Line 45: protected boolean hashComputed = false; not used? PS6, Line 106: hashComputed = false; remove? -- To view, visit https://asterix-gerrit.ics.uci.edu/2069 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90ab0d0b2da0028e0ec3cfa94d21881318293ff7 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
