Xikui Wang has posted comments on this change. Change subject: [ASTERIXDB-2136][FUN] Prevent blind result write in external UDF ......................................................................
Patch Set 2: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2082/2/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/generator/DataGenerator.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/generator/DataGenerator.java: PS2, Line 424: buffer.append("#" + jargonTerm); > Is this related to this change, or fixing a bug simultaneously? This is to enable the UDF can discover related topics. https://asterix-gerrit.ics.uci.edu/#/c/2082/2/asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/AddHashTagsFunction.java File asterixdb/asterix-external-data/src/test/java/org/apache/asterix/external/library/AddHashTagsFunction.java: Line 80: > Same question here This line is not needed here as the result is the outputRecord. -- To view, visit https://asterix-gerrit.ics.uci.edu/2082 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifce4a9e882febe4529f5c53e54db78e0cfa326fe Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
