abdullah alamoudi has submitted this change and it was merged. Change subject: [NO ISSUE][RT] Prevent setting AMutableString value to null ......................................................................
[NO ISSUE][RT] Prevent setting AMutableString value to null - user model changes: no - storage format changes: no - interface changes: no Details: - An instance of AMutableString can't hold null value. Change-Id: I8e7b19b190120e64ec78b41f26ef54fce9660e27 Reviewed-on: https://asterix-gerrit.ics.uci.edu/2090 Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Contrib: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: Michael Blow <[email protected]> --- M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AMutableString.java 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Anon. E. Moose #1000171: Jenkins: Verified; No violations found; ; Verified Michael Blow: Looks good to me, approved diff --git a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AMutableString.java b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AMutableString.java index 33217cd..b2a4a5e 100644 --- a/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AMutableString.java +++ b/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AMutableString.java @@ -20,11 +20,16 @@ public class AMutableString extends AString { + private static final long serialVersionUID = 1L; + public AMutableString(String value) { super(value); } public void setValue(String value) { + if (value == null) { + throw new NullPointerException(); + } this.value = value; } } -- To view, visit https://asterix-gerrit.ics.uci.edu/2090 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8e7b19b190120e64ec78b41f26ef54fce9660e27 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]>
