Murtadha Hubail has posted comments on this change. Change subject: [ASTERIXDB-1076][HYR] Prevent node death false positives ......................................................................
Patch Set 4: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2097/3/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/AbstractTaskLifecycleWork.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/AbstractTaskLifecycleWork.java: PS3, Line 79: final NodeControllerState ncState = ccs.getNodeManager().getNodeControllerState(nodeId); : if (ncState != null) { : ncState.touchHeartbeat(); : } This isn't needed. This already extends AbstractHeartbeatWork which will do the same thing. -- To view, visit https://asterix-gerrit.ics.uci.edu/2097 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idb1abcc2b783b192b88ed988d398fcfe763531e9 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
