Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2015][IDX] Introduce Primary Index Optimization Rule ......................................................................
Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2111/1/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroducePrimaryIndexForAggregationRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroducePrimaryIndexForAggregationRule.java: Line 70: * Can you document the output of this rule here? Line 75: public class IntroducePrimaryIndexForAggregationRule implements IAlgebraicRewriteRule { Please add testcases for this rule. asterix-app/.../runtimets - data tests and asterix-app/.../optimizerts - optimizer tests. They should test all cases covered by this rule. i.e. over datasourcescan / unnest-map, with / without assign, etc. -- To view, visit https://asterix-gerrit.ics.uci.edu/2111 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3bbb2b5e1f25e61928d73b866e91c592ce0bf954 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
