Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-2081][STO] Introduce DatasetMemoryManager ......................................................................
Patch Set 4: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/2112/4/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/txn/RecoveryManagerTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/txn/RecoveryManagerTest.java: PS4, Line 60: String.valueOf("128MB") remove redundant String.valueOf() PS4, Line 61: String.valueOf("32") remove redundant String.valueOf() https://asterix-gerrit.ics.uci.edu/#/c/2112/4/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetMemoryManager.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetMemoryManager.java: PS4, Line 35: ConcurrentHashMap no need to be concurrent, all access is synchronized PS4, Line 36: ConcurrentHashMap no need to be concurrent, all access is synchronized PS4, Line 37: AtomicLong no need for atomic- all writes are synchronized https://asterix-gerrit.ics.uci.edu/#/c/2112/4/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/bootstrap/MetadataBootstrap.java: Line 308: throw new IllegalStateException("Failed to reserve memory for metadata dataset(" + datasetId + ")"); space? -- To view, visit https://asterix-gerrit.ics.uci.edu/2112 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ica76b3c8eca6f7d2ad1d962fb5ef84267c258571 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
